Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: Add 2.0.20 support #16932

Merged
merged 6 commits into from
Jul 16, 2024
Merged

Kotlin: Add 2.0.20 support #16932

merged 6 commits into from
Jul 16, 2024

Conversation

igfoo
Copy link
Contributor

@igfoo igfoo commented Jul 8, 2024

No description provided.

@igfoo igfoo marked this pull request as ready for review July 8, 2024 18:42
@igfoo igfoo requested review from a team as code owners July 8, 2024 18:42
@oscarsj
Copy link
Contributor

oscarsj commented Jul 9, 2024

I added an internal check run over this changeset here https://github.com/github/semmle-code/actions/runs/9854237798/job/27206567419 but the "Check kotlin versions" job does not seem fixed , shouldn't the contents of this PR fix that workflow?

@igfoo
Copy link
Contributor Author

igfoo commented Jul 9, 2024

I think the problem is that the in-tree codeql dist is no longer complete; I'll switch the test to use the full dist

@igfoo igfoo force-pushed the igfoo/kotlin-2.0.20 branch from d18d308 to 2e34489 Compare July 9, 2024 11:28
tamasvajk
tamasvajk previously approved these changes Jul 10, 2024
View reviewed changes
@igfoo igfoo force-pushed the igfoo/kotlin-2.0.20 branch from 2e34489 to 8adb9ba Compare July 11, 2024 11:11
@igfoo igfoo force-pushed the igfoo/kotlin-2.0.20 branch 2 times, most recently from 4e7f98b to 7836b09 Compare July 15, 2024 14:26
smowton
smowton approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing approval by @tamasvajk, haven't re-reviewed

@igfoo igfoo force-pushed the igfoo/kotlin-2.0.20 branch from 7836b09 to 91dd99d Compare July 16, 2024 14:07
@igfoo igfoo merged commit bf4a202 into github:main Jul 16, 2024
28 of 31 checks passed
@igfoo igfoo deleted the igfoo/kotlin-2.0.20 branch July 16, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smowton smowton smowton approved these changes

@tamasvajk tamasvajk tamasvajk left review comments

Assignees
No one assigned
Labels
documentation Java Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@igfoo @oscarsj @smowton @tamasvajk