C#: Fix quality issues #16871
Merged
C#: Fix quality issues #16871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
136
to
143
| catch (Exception ex) | ||
| { | ||
| // If this happened, it was probably because | ||
| // - the same file was compiled multiple times, or | ||
| // - the file doesn't exist (due to wrong #line directive or because it's an in-memory source generated AST). | ||
| // In any case, this is not a fatal error. | ||
| logger.LogWarning("Problem archiving " + dest + ": " + ex); | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
Comment on lines
120
to
124
| catch (Exception ex) // lgtm[cs/catch-of-all-exceptions] | ||
| { | ||
| logger.LogError($" Unhandled exception: {ex}"); | ||
| return ExitCode.Errors; | ||
| } |
Check notice
Code scanning / CodeQL
Generic catch clause Note
tamasvajk
force-pushed
the
fix/quality-issues
branch
from
42db708 to
158537b
Compare
tamasvajk
force-pushed
the
fix/quality-issues
branch
from
158537b to
199a968
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.