Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go: update extractor dependencies #16737

Closed
wants to merge 2 commits into from

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Jun 12, 2024

I updated the dependencies in go.mod and ran make gen to update the vendored dependencies. This should help us stay up-to-date with the latest security patches and bug fixes.

The motivation for doing this is that I'm adding another package dependency in a different branch and its easier to make that small change if we're already up-to-date with our dependencies.

@owen-mc
Copy link
Contributor Author

owen-mc commented Jun 13, 2024

I ran DCA and it showed nothing of note.

mbg
mbg previously approved these changes Jun 14, 2024
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to merge this instead of the Dependabot PR since you updated the Bazel files already here. Just need to resolve the merge conflict that got introduced as a result of the updates needed to remove the go.work file

@owen-mc owen-mc force-pushed the go/update-extractor-dependencies branch from 1ebe8c1 to b937489 Compare June 14, 2024 09:03
@owen-mc
Copy link
Contributor Author

owen-mc commented Jun 14, 2024

I resolved the conflict manually, then reran make gen to make sure that it didn't update anything further. (It didn't.)

@owen-mc owen-mc closed this Jul 18, 2024
@owen-mc owen-mc deleted the go/update-extractor-dependencies branch July 18, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants