Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kotlin: cleanup after internal changes #16720

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Kotlin: cleanup after internal changes #16720

merged 6 commits into from
Jun 14, 2024

Conversation

redsun82
Copy link
Contributor

No description provided.

@redsun82 redsun82 requested a review from criemen June 11, 2024 06:52
@redsun82 redsun82 requested a review from a team as a code owner June 11, 2024 06:52
@redsun82 redsun82 marked this pull request as draft June 11, 2024 07:37
@redsun82 redsun82 added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Jun 11, 2024
@redsun82
Copy link
Contributor Author

ah, forgot it's still used by an internal PR, we need to clean that up before merging this.

@redsun82 redsun82 marked this pull request as ready for review June 11, 2024 08:15
@redsun82
Copy link
Contributor Author

ah, forgot it's still used by an internal PR, we need to clean that up before merging this.

done, the internal checks got indeed past the build phase now 👍

@criemen
Copy link
Collaborator

criemen commented Jun 11, 2024

Hm, CI is still broken. I'm not convinced 😬

@redsun82
Copy link
Contributor Author

Hm, CI is still broken. I'm not convinced 😬

uh, I wonder whether the internal PR didn't break those. Language tests might not have been triggered on that.

@redsun82
Copy link
Contributor Author

I can't understand how this PR could cause that failure, as if this PR had an influence, it would just break the build, not the language test running. semmle-code main is indeed clean, but I've started a run with semmle-code main and codeql main (simulating a ql bump).

@redsun82 redsun82 marked this pull request as draft June 12, 2024 07:46
@redsun82
Copy link
Contributor Author

This must wait for #16731 and an internal PR

@redsun82 redsun82 changed the title Kotlin: remove obsolete scripts and reword comments Kotlin: cleanup after internal changes Jun 13, 2024
@redsun82 redsun82 changed the base branch from main to redsun82/kotlin-fix-version-picker June 13, 2024 07:41
Base automatically changed from redsun82/kotlin-fix-version-picker to main June 13, 2024 11:57
@redsun82 redsun82 marked this pull request as ready for review June 13, 2024 14:29
@redsun82 redsun82 requested a review from a team as a code owner June 13, 2024 14:29
redsun82
redsun82 commented Jun 13, 2024
View reviewed changes
java/ql/lib/change-notes/2024-06-13-kotlin-qltest-support.md Outdated
---
category: fix
---
* Support of `codeql test run` for Kotlin sources has been fixed.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@igfoo does this sound right? Or would you prefer another wording?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably have written "Support for".

igfoo
igfoo previously approved these changes Jun 13, 2024
View reviewed changes
criemen
criemen approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@criemen criemen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for Ian.

@redsun82 redsun82 merged commit e2a47e7 into main Jun 14, 2024
16 checks passed
@redsun82 redsun82 deleted the redsun82/kotlin branch June 14, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igfoo igfoo igfoo left review comments

@criemen criemen criemen approved these changes

Assignees
No one assigned
Labels
depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation Java Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@redsun82 @criemen @igfoo