Rust: Move to bzlmod. #16716
Merged
Rust: Move to bzlmod. #16716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gets rid of our last workspace dependency. In particular, this change also gets rid of the checked-in extra lock files that took forever to generate.
This also bumps a bunch of external dependencies.
criemen
added
the
depends on internal PR
criemen
force-pushed
the
criemen/rust-bzlmod-new
branch
from
8177a9b to
496fff4
Compare
tausbn
approved these changes
Jun 10, 2024
aibaars
approved these changes
Jun 10, 2024
|
We need an internal PR for this, as the path to the build targets change, otherwise I'm not aware that anything is broken. |
erik-krogh
approved these changes
Jun 10, 2024
redsun82
approved these changes
Jun 11, 2024
| visibility = None, | ||
| symbols_test = True, | ||
| **kwargs): | ||
| rust_label_name = name + "_single_arch" |
There was a problem hiding this comment.
wouldn't it be maybe better to use single_arch/name, to get a consistent binary base name?
| @@ -0,0 +1,23 @@ | |||
| load("@rules_rust//rust:defs.bzl", "rust_binary") | |||
| load("@semmle_code//buildutils-internal:glibc_symbols_check.bzl", "glibc_symbols_check") | |||
| load("@semmle_code//buildutils-internal:lipo.bzl", "universal_binary") | |||
There was a problem hiding this comment.
not in the context of this PR, but we probably should think about moving this rule in this repo or go with the separate bazel lib repo idea we had
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gets rid of our last workspace dependency.
In particular, this change also gets rid of the checked-in extra
lock files that took forever to generate.
This PR also upgrades bazel to 7.2.0 while we're at it, and upgrades a bunch of external dependencies.