C#: Add assembly attributes to assemblies built with Bazel #16705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each unit gets a unique assemblyInfo file, on top of the ones for entrypoints that also gets the git info embedded.
criemen
approved these changes
Jun 7, 2024
| [assembly: AssemblyCompany("GitHub")] | ||
| [assembly: AssemblyCopyright("Copyright © 2024 GitHub")] | ||
|
|
||
| [assembly: System.Runtime.Versioning.TargetFramework(".NETCoreApp,Version=v8.0", FrameworkDisplayName = ".NET 8.0")] |
There was a problem hiding this comment.
Should we record in the C# wiki that this requires updating when we upgrade .NET?
There was a problem hiding this comment.
Good point. I'm doing it.
michaelnebel
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the build configuration for C# projects:
AssemblyInfo.csfiles and movesInternalsVisibleToAttributesto csproj files."Properties/*.cs"source declarations from Bazel build scripts.