Tree-sitter: Extract non-whitespace tokens between sibling nodes #16433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
tree-sitter/extra-tokens
branch
from
794a632 to
dc5fb30
Compare
hvitved
changed the title
|
I think this is not the right fix. The problem is that the tree-sitter grammar declares the contents of a character literal to be uninteresting. Better fix the grammar instead of working around this in the extractor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the C# tree-sitter grammar means that for non-escaped character literals, such as
'c', we would not extract the character contentc. This PR tries to solve the underlying issue in general, by always extracting "extra" non-whitespace tokens that sit in between two other nodes. I have verified that with this change, we are able to extract character literals correctly.A similar situation happens for the JSON Tree-sitter grammar.