Go: fix flow through string concatenation in go/incomplete-hostname-regexp
#16307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-mc
force-pushed
the
go/fix/incomplete-hostname-regex
branch
from
b56b1f9 to
c61177c
Compare
|
MRVA didn't show any extra results on the top 1000 go repos. I did find an extra result on the repo which prompted this investigation (which was prompted by the investigation of two extra results for Go: extractor: do not store intermediate values in long string concatenations). |
|
DCA (for just this query) showed no alert changes and no significant change in analysis time. |
smowton
approved these changes
Apr 25, 2024
owen-mc
changed the title
go/incomplete-hostname-regexgo/incomplete-hostname-regexp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The source definition (which dates back to the first commit for the codeql-go repo) was trying to avoid duplicated results, but in a way that didn't work. The problem was that we don't make expression nodes for the operands of an expression like
"a" + "b"when we have a constant value for the whole expression. This PR changes how we avoid duplicate results so that it shouldn't miss any sources. It also adds flow through string concatenation and some extra tests.