C++: Remove an unnecessary column #16299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onally determined by the address column.
MathiasVP
force-pushed
the
remove-base-address-as-ipa-key
branch
from
41de946 to
6564582
Compare
geoffw0
approved these changes
May 8, 2024
| TDirectDefImpl(BaseSourceVariableInstruction base, Operand address, int indirectionIndex) { | ||
| isDef(_, _, address, base, _, indirectionIndex) | ||
| TDirectDefImpl(Operand address, int indirectionIndex) { | ||
| isDef(_, _, address, _, _, indirectionIndex) |
There was a problem hiding this comment.
So we never had two TDirectDefImpl with the same address / indirectionIndex but different bases?
There was a problem hiding this comment.
Correct. That would only be possible if an operand somehow had two base instructions. And we don't generate that kind of IR
Good question. I tried running both queries locally and they produce exactly the same set of results. I think it may be related to these queries on those projects generating very large bqrs files, and since the size of the bqrs file is very larg ethe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a small cleanup that shouldn't have any external impact. The
BaseSourceVariableInstructioncolumn is functionally determined by the other columns, so we can simply remove it.DCA was uneventful