Python: Rename StrConst to StringLiteral
#16245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does a few things: - Renames `StrConst` to `StringLiteral`, and deprecates the former. - Also deprecates `Str`. - Adds an override of `StringLiteral::toString` making it output `"StringLiteral"` rather than the inherited `"Str"`. This ensures that the AST viewer shows these nodes as the former type, not the latter. There are a large number of uses of `StrConst` in the codebase. These will be fixed in a later commit.
Done using ``` git grep StrConst | xargs sed -i 's/StrConst/StringLiteral/g' ```
Of course, `StringLiteral` being much longer than `StrConst` meant a bunch of files changed formatting.
As far as I can tell, this was the only occurrence of `Str` as a type throughout the entire library.
I'm beginning to realise why I didn't do the `toString` overriding way back when. Thankfully, now that all of our tests are in the same place, this is actually not a terrible ordeal.
tausbn
force-pushed
the
tausbn/python-rename-StrConst-to-StringLiteral
branch
from
5d1fca8 to
bab461f
Compare
RasmusWL
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes the job that #9852 started, renaming
StrandStrConstintoStringLiteral, and deprecating the former two classes. Moreover, thetoStringofStringLiteralis overridden so that it returns the correct string. This ensures that the AST viewer shows the correct class for all strings in the source code.Reviewing commit-by-commit is recommended.