Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C#: Take more sources and sinks into account when reporting in the te… #16215

Merged
merged 6 commits into from
Apr 17, 2024
Merged

C#: Take more sources and sinks into account when reporting in the te… #16215

merged 6 commits into from
Apr 17, 2024

Conversation

michaelnebel
Copy link
Contributor

…lemetry queries.

@github-actions github-actions bot added the C# label Apr 15, 2024
@michaelnebel michaelnebel force-pushed the csharp/telemetryissupported branch 2 times, most recently from 7f35e50 to 824db04 Compare April 16, 2024 08:17
@michaelnebel michaelnebel force-pushed the csharp/telemetryissupported branch 5 times, most recently from 8a43909 to ad0d911 Compare April 16, 2024 13:30
@michaelnebel michaelnebel force-pushed the csharp/telemetryissupported branch from ad0d911 to 4a4f9b3 Compare April 16, 2024 14:06
@michaelnebel
Copy link
Contributor Author

DCA shows a performance decrease of around 3% and a significant DIL increase for the telemetry queries, which is not surprising as they now have a dependency to most of the *Querl.qll files.
DCA also reports a significant slowdown for some of the queries, but that could be caused by evaluation order. Will start another DCA experiment, where we just run a single telemetry query in isolation.

@michaelnebel michaelnebel marked this pull request as ready for review April 17, 2024 06:45
@michaelnebel michaelnebel requested a review from a team as a code owner April 17, 2024 06:45
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Apr 17, 2024
@michaelnebel
Copy link
Contributor Author

DCA shows

  • Increase in DIL size (expected).
  • Increase in cache size (not unreasonable as we are adding lots of dependencies).
  • A slowdown of the telemetry queries with around 15% (also not unexpected).
    I also tried running the cs/telemetry/supported-external-apis locally from a cold cache on mono which confirms the (not unreasonable) slowdown.

@michaelnebel michaelnebel merged commit 4d3d07a into github:main Apr 17, 2024
21 checks passed
@michaelnebel michaelnebel deleted the csharp/telemetryissupported branch April 17, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelnebel @hvitved