Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swift: add shared/** to CI triggers #16199

Merged
merged 1 commit into from
Apr 12, 2024
Merged

Swift: add shared/** to CI triggers #16199

merged 1 commit into from
Apr 12, 2024

Conversation

redsun82
Copy link
Contributor

Not being triggered by changes in shared was making it possible to not notice changes in shared having effect on Swift tests. For example this PR introduced a test change that was fixed here.

@redsun82
Swift: add shared/** to CI triggers
de4ffbb 
Not being triggered by changes in shared was making it possible to not
notice changes in `shared` having effect on Swift tests. For example
[this PR](#15501) introduced a
test change that was fixed [here](#16197).
@redsun82 redsun82 requested a review from MathiasVP April 12, 2024 13:48
@redsun82 redsun82 requested a review from a team as a code owner April 12, 2024 13:48
MathiasVP
MathiasVP approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@redsun82 redsun82 merged commit 3614d3d into main Apr 12, 2024
15 checks passed
@redsun82 redsun82 deleted the redsun82/add-shared-triggers-to-swift-ci branch April 12, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasVP MathiasVP MathiasVP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @MathiasVP