Go: Add SQLi sinks for Squirrel #15812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
previously approved these changes
Mar 5, 2024
owen-mc
reviewed
Mar 5, 2024
| fn.(Method).hasQualifiedName(sq, builder, "Where") | ||
| // first argument to the `OrderBy`, `Prefix`, `Suffix` or `Where` method of one of the `*Builder` classes | ||
| exists(Method m, string builder | m = fn | | ||
| builder.matches("%Builder") and |
There was a problem hiding this comment.
While you're editing this code, can you just explicitly list the types? It makes it much easier to search for and there aren't that many.
There was a problem hiding this comment.
I think it's this:
Suggested change
| builder.matches("%Builder") and | |
| builder = ["DeleteBuilder", "InsertBuilder", "SelectBuilder", "UpdateBuilder"] and |
There was a problem hiding this comment.
Sure, done here: e78e71c.
smowton
approved these changes
Mar 5, 2024
owen-mc
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds SQL injection sinks for https://github.com/Masterminds/squirrel.