Java: Bring the Model Diff workflow back into a working state. #15225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
java/modeldiffworkflow
branch
4 times, most recently
from
9556819 to
8048a1e
Compare
michaelnebel
force-pushed
the
java/modeldiffworkflow
branch
from
cb89bf8 to
04a724f
Compare
michaelnebel
changed the title
michaelnebel
changed the title
owen-mc
approved these changes
Jan 9, 2024
|
@owen-mc : Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out that the Model Diff workflow didn't work after changes to the model generator script that generates a YAML file for each package.
In this PR we bring the workflow back into a working state; Note that the comparison is only made for files that also exist on the main branch. In any case - all modes are still upload as a part of the artefact.