Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift: Add some tests and model SecKeyCopyExternalRepresentation #15007

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Dec 5, 2023

This PR does two things:

  • adds some tests of things that look like encryption keys (and certificates) as sensitive data that I had lying around in a local commit. These aren't currently flagged because heuristics based on the word "key" tend to produce a lot of false positives - but they're important cases we should figure out at some point (there is already an issue tracking this).
  • solve a small slice of the problem by creating an explicit model for SecKeyCopyExternalRepresentation(::), that turns a SecKey object into data (which could potentially be stored or transmitted). This is the first sensitive data source defined explicitly using models-as-data - so a bit of plumbing is involved as well.

@geoffw0 geoffw0 added the Swift label Dec 5, 2023
@geoffw0 geoffw0 requested a review from a team as a code owner December 5, 2023 13:38
Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@geoffw0 geoffw0 merged commit 32fdf4f into github:main Dec 7, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants