Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "C#: Split generated/dotnet_runtime.yml into separate files" #14674

Merged
merged 1 commit into from
Nov 3, 2023

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Nov 3, 2023

Reverts #14663

@hvitved hvitved requested a review from a team as a code owner November 3, 2023 08:08
@github-actions github-actions bot added the C# label Nov 3, 2023
@hvitved hvitved added the no-change-note-required This PR does not need a change note label Nov 3, 2023
Copy link
Contributor

github-actions bot commented Nov 3, 2023

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

csharp

Generated file changes for csharp

  • Changes to framework-coverage-csharp.rst:
-    System,"``System.*``, ``System``",25,12738,65,7
+    System,"``System.*``, ``System``",25,12149,65,7
-    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,578,138,
+    Others,"``Dapper``, ``JsonToItemsTaskFactory``, ``Microsoft.ApplicationBlocks.Data``, ``Microsoft.CSharp``, ``Microsoft.EntityFrameworkCore``, ``Microsoft.Extensions.Caching.Distributed``, ``Microsoft.Extensions.Caching.Memory``, ``Microsoft.Extensions.Configuration``, ``Microsoft.Extensions.DependencyInjection``, ``Microsoft.Extensions.DependencyModel``, ``Microsoft.Extensions.FileProviders``, ``Microsoft.Extensions.FileSystemGlobbing``, ``Microsoft.Extensions.Hosting``, ``Microsoft.Extensions.Http``, ``Microsoft.Extensions.Logging``, ``Microsoft.Extensions.Options``, ``Microsoft.Extensions.Primitives``, ``Microsoft.Interop``, ``Microsoft.NET.Build.Tasks``, ``Microsoft.NETCore.Platforms.BuildTasks``, ``Microsoft.VisualBasic``, ``Microsoft.Win32``, ``MySql.Data.MySqlClient``, ``Newtonsoft.Json``, ``Windows.Security.Cryptography.Core``",,568,138,
-    Totals,,25,13323,397,7
+    Totals,,25,12724,397,7
  • Changes to framework-coverage-csharp.csv:
- Microsoft.Extensions.FileSystemGlobbing,,,16,,,,,,,,,,,,,,14,2
+ Microsoft.Extensions.FileSystemGlobbing,,,15,,,,,,,,,,,,,,13,2
- Microsoft.Extensions.Logging,,,38,,,,,,,,,,,,,,38,
+ Microsoft.Extensions.Logging,,,37,,,,,,,,,,,,,,37,
- Microsoft.Extensions.Options,,,16,,,,,,,,,,,,,,16,
+ Microsoft.Extensions.Options,,,8,,,,,,,,,,,,,,8,
- System,65,25,12738,,8,8,9,,,4,3,33,1,17,3,4,10730,2008
+ System,65,25,12149,,8,8,9,,,4,3,33,1,17,3,4,10163,1986

Copy link
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@hvitved hvitved merged commit c34ad25 into main Nov 3, 2023
15 of 16 checks passed
@hvitved hvitved deleted the revert-14663-csharp/split-generated-mad-files branch November 3, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C# no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants