C#: Move qualified name computation into QualifiedName.qll
#14657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
csharp/qualified-name
branch
from
c5c4295 to
399327e
Compare
hvitved
force-pushed
the
csharp/qualified-name
branch
from
399327e to
c717e34
Compare
tamasvajk
previously approved these changes
Nov 2, 2023
Comment on lines
70
to
72
| vort instanceof VoidType and | ||
| qualifier = "System" and | ||
| name = "Void" |
There was a problem hiding this comment.
Why do we need to special case VoidType?
Couldn't the below cover it?
not exists(vort.getDeclaringType()) and
qualifier = vort.getNamespace().getFullName() and
name = vort.getUndecoratedName()
There was a problem hiding this comment.
Perhaps; I just copied over the existing logic.
Comment on lines
84
to
85
| qualifier = "System" and | ||
| name = "Nullable<" + getFullName(vort.(NullableType).getUnderlyingType()) + ">" |
There was a problem hiding this comment.
Is this needed? NullableType is a subclass of ConstructedType, couldn't the below any(ConstructedType ct | ... cover nullable types too?
There was a problem hiding this comment.
Again, I just copied it from the existing setup, but I can try to remove it.
michaelnebel
approved these changes
Nov 2, 2023
tamasvajk
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the logic for computing fully qualified names into
QualifiedName.qll, and makes it parameterized on how to print unbound generics. This is in preparation for a change to the Models-as-Data format for C#.