Swift: QLDoc and test for getCanonicalType #14618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
reviewed
Oct 27, 2023
swift/schema.py
Outdated
| canonical_type: "Type" | desc(""" | ||
| This is the unique type we get after resolving aliases and desugaring. For example, given | ||
| ``` | ||
| typealias MyInt == Int |
There was a problem hiding this comment.
I don't think == is valid Swift here, is it?
MathiasVP
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more detailed QLDoc and test for
Type.getCanonicalType(). This is a useful method that I've not used until now because, frankly, I didn't really know what it did. Now I do and others can too.Thanks to @rdmarsh2 for providing the first version of the text for this in #14592 (comment) .