Update Change-note-check workflow to detect changes in shared folder
#14613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that the "check change note" CI check failed when I made a change to |
owen-mc
force-pushed
the
change-note-check-on-shared
branch
from
f9ca117 to
1db622e
Compare
henrymercer
approved these changes
Oct 27, 2023
|
Hmm. Why is the "Check change note" CI check there? Is it because there was a file which needed that check, and even after I force-pushed to remove that file the check doesn't go away? I tried rerunning it and it still failed, which makes sense as it's just checking whether there's a change note. |
|
The workflow has a (sensible) trigger on changes to itself: Jut add the label, and it should be okay I think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.