Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FlowSummaryImpl.qll to dataflow pack #14573

Merged
merged 14 commits into from
Dec 14, 2023

Address more review comments

098afb9
Select commit
Loading
Failed to load commit list.
Merged

Move FlowSummaryImpl.qll to dataflow pack #14573

Address more review comments
098afb9
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Dec 14, 2023 in 6s

2 configurations not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 2 configurations present on refs/heads/main were not found:

Actions workflow (csv-coverage-metrics.yml)

  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-csharp
  • ❓  .github/workflows/csv-coverage-metrics.yml:publish-java

New alerts in code changed by this pull request

  • 3 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 1752 in shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Predicate QLDoc style. Warning

The QLDoc for a predicate without a result should start with 'Holds'.

Check warning on line 1536 in shared/dataflow/codeql/dataflow/internal/FlowSummaryImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Dead code Warning

This code is never used, and it's not publicly exported.

Check warning on line 159 in csharp/ql/lib/semmle/code/csharp/dataflow/internal/FlowSummaryImpl.qll

See this annotation in the file changed.

Code scanning / CodeQL

Names only differing by case Warning

Cs is only different by casing from CS that is used elsewhere for modules.