JS: New Command Execution Sinks #14198
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
| } | ||
|
|
||
| // Holds if left parameter is the the left child of a template literal and returns the template literal |
Check warning
Code scanning / CodeQL
Comment has repeated word
| // Holds whether Execa has shell enabled options or not, get Parameter responsible for options | ||
| private predicate isExecaShellEnable(API::Node n) { | ||
| n.getMember("shell").asSink().asExpr().(BooleanLiteral).getValue() = "true" and | ||
| exists(n.getMember("shell")) |
Check warning
Code scanning / CodeQL
Superfluous 'exists' conjunct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Execa package before version 5 has already been modeled but newer versions up to 8 have many new APIs that I've implemented now.
Shelljs package also have a piping feature which I've updated the current shelljs module to support piping too.
Also, dynamic import in nodejs support URLs starts with
data:which is dangerous.There is another nodejs API that accepts the
data:URL which is:but it needs to be a URL Type as input, not any string value that starts with
data:, I'm not sure what is the best way to implement it.