Code quality improvement

github · Mar 22, 2024 · fa7f437 · fa7f437
1 parent 322fb6c
commit fa7f437
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/CompilerDiagnostic.cs b/csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/CompilerDiagnostic.cs
@@ -6,7 +6,7 @@ namespace Semmle.Extraction.CSharp.Entities
 {
     internal class CompilerDiagnostic : FreshEntity
     {
-        private static readonly int limit = EnvironmentVariables.TryGetExtractorOption<int>("COMPILER_DIAGNOSTIC_LIMIT") ?? 1000;
+        private static readonly int limit = EnvironmentVariables.TryGetExtractorNumberOption<int>("COMPILER_DIAGNOSTIC_LIMIT") ?? 1000;
         private static readonly ConcurrentDictionary<string, int> messageCounts = new();
 
         private readonly Microsoft.CodeAnalysis.Diagnostic diagnostic;

diff --git a/csharp/extractor/Semmle.Extraction/Entities/ExtractionMessage.cs b/csharp/extractor/Semmle.Extraction/Entities/ExtractionMessage.cs
@@ -6,7 +6,7 @@ namespace Semmle.Extraction.Entities
 {
     internal class ExtractionMessage : FreshEntity
     {
-        private static readonly int limit = EnvironmentVariables.TryGetExtractorOption<int>("MESSAGE_LIMIT") ?? 10000;
+        private static readonly int limit = EnvironmentVariables.TryGetExtractorNumberOption<int>("MESSAGE_LIMIT") ?? 10000;
         private static int messageCount = 0;
 
         private readonly Message msg;

diff --git a/csharp/extractor/Semmle.Util/EnvironmentVariables.cs b/csharp/extractor/Semmle.Util/EnvironmentVariables.cs
@@ -9,7 +9,7 @@ public class EnvironmentVariables
         public static string? GetExtractorOption(string name) =>
             Environment.GetEnvironmentVariable($"CODEQL_EXTRACTOR_CSHARP_OPTION_{name.ToUpper()}");
 
-        public static T? TryGetExtractorOption<T>(string name) where T : struct, INumberBase<T>
+        public static T? TryGetExtractorNumberOption<T>(string name) where T : struct, INumberBase<T>
         {
             var value = GetExtractorOption(name);
             if (T.TryParse(value, NumberStyles.Number, CultureInfo.InvariantCulture, out var result))