C#: Improve global.json file parsing

github · Mar 7, 2024 · ea38bf5 · ea38bf5
1 parent 66d2a84
commit ea38bf5
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs b/csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DotNet.cs
@@ -131,11 +131,16 @@ private static BuildScript DownloadDotNet(IBuildActions actions, ILogger logger,
                 try
                 {
                     var o = JObject.Parse(File.ReadAllText(path));
-                    versions.Add((string)o?["sdk"]?["version"]!);
+                    var v = (string?)o?["sdk"]?["version"];
+                    if (v is not null)
+                    {
+                        versions.Add(v);
+                    }
                 }
                 catch
                 {
                     // not a valid `global.json` file
+                    logger.LogInfo($"Couldn't find .NET SDK version in '{path}'.");
                     continue;
                 }
             }