Skip to content

Commit

Permalink
Merge pull request #15305 from github/alexdenisov/revert-swift-change
Browse files Browse the repository at this point in the history
Revert "Swift: separate installation of dependencies and autobuilding"
  • Loading branch information
alexet authored Jan 12, 2024
2 parents b209ea6 + 28dd2e9 commit b2f1fbe
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions swift/swift-autobuilder/swift-autobuilder.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,6 @@ static bool buildSwiftPackages(const std::vector<std::filesystem::path>& swiftPa
return any_successful;
}

static void installDependencies(const CLIArgs& args) {
auto structure = scanProjectStructure(args.workingDir);
installDependencies(structure, args.dryRun);
}

static bool autobuild(const CLIArgs& args) {
auto structure = scanProjectStructure(args.workingDir);
auto& xcodeTargets = structure.xcodeTargets;
Expand Down Expand Up @@ -87,6 +82,7 @@ static bool autobuild(const CLIArgs& args) {
return false;
} else if (!xcodeTargets.empty()) {
LOG_INFO("Building Xcode target: {}", xcodeTargets.front());
installDependencies(structure, args.dryRun);
auto buildSucceeded = buildXcodeTarget(xcodeTargets.front(), args.dryRun);
// If build failed, try to build Swift packages
if (!buildSucceeded && !swiftPackages.empty()) {
Expand Down Expand Up @@ -117,7 +113,6 @@ static CLIArgs parseCLIArgs(int argc, char** argv) {

int main(int argc, char** argv) {
auto args = parseCLIArgs(argc, argv);
installDependencies(args);
auto success = autobuild(args);
codeql::Log::flush();
if (!success) {
Expand Down

0 comments on commit b2f1fbe

Please sign in to comment.