Include changes from review

github · Oct 20, 2024 · 7ef2d79 · 7ef2d79
1 parent e2dd126
commit 7ef2d79
Showing 1 changed file with 7 additions and 11 deletions.
diff --git a/python/ql/lib/semmle/python/frameworks/Pycurl.qll b/python/ql/lib/semmle/python/frameworks/Pycurl.qll
@@ -90,17 +90,13 @@ module Pycurl {
       override predicate disablesCertificateValidation(
         DataFlow::Node disablingNode, DataFlow::Node argumentOrigin
       ) {
-        exists(API::CallNode c |
-          c = setopt().getACall() and
-          sslverifypeer().getAValueReachableFromSource() = c.getArg(0) and
-          (
-            exists(IntegerLiteral i | i.getValue() = 0 and c.getArg(1).asExpr() = i)
-            or
-            exists(BooleanLiteral b | b.booleanValue() = false)
-          )
-        |
-          disablingNode = c and argumentOrigin = c.getArg(1)
-        )
+        sslverifypeer().getAValueReachableFromSource() = this.getArg(0) and
+        (
+          exists(IntegerLiteral i | i.getValue() = 0 and this.getArg(1).asExpr() = i)
+          or
+          exists(BooleanLiteral b | b.booleanValue() = false and this.getArg(_).asExpr() = b)
+        ) and
+        (disablingNode = this and argumentOrigin = this.getArg(1))
       }
     }
   }