Skip to content

Commit

Permalink
Add missing qldoc and revert accidentilly commited threat model change
Browse files Browse the repository at this point in the history
  • Loading branch information
joefarebrother committed Dec 11, 2024
1 parent bcb08bb commit 652a9ca
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 2 deletions.
12 changes: 12 additions & 0 deletions python/ql/lib/semmle/python/frameworks/Lxml.qll
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,17 @@ module Lxml {
/** Gets a reference to the `Element` class. */
API::Node classRef() { result = etreeRef().getMember(["Element", "_Element"]) }

/**
* A source of instances of `lxml.etree.Element` instances, extend this class to model new instances.
*
* This can include instantiations of the class, return values from function
* calls, or a special parameter that will be set when functions are called by an external
* library.
*
* Use the predicate `Element::instance()` to get references to instances of `lxml.etree.ElementTree` instances.
*/
abstract class InstanceSource instanceof API::Node {
/** Gets a textual representation of this element. */
string toString() { result = super.toString() }
}

Expand Down Expand Up @@ -410,6 +420,7 @@ module Lxml {

/** Provides models for instances of the `lxml.etree.ElementTree` class. */
module ElementTree {
/** Gets a reference to the `ElementTree` class. */
API::Node classRef() { result = etreeRef().getMember(["ElementTree", "_ElementTree"]) }

/**
Expand All @@ -422,6 +433,7 @@ module Lxml {
* Use the predicate `ElementTree::instance()` to get references to instances of `lxml.etree.ElementTree` instances.
*/
abstract class InstanceSource instanceof API::Node {
/** Gets a textual representation of this element. */
string toString() { result = super.toString() }
}

Expand Down
3 changes: 1 addition & 2 deletions shared/threat-models/ext/supported-threat-models.model.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,4 @@ extensions:
pack: codeql/threat-models
extensible: threatModelConfiguration
data:
- ["default", true, -2147483648] # The "default" threat model is included by default
- ["all", true, 1]
- ["default", true, -2147483648] # The "default" threat model is included by default

0 comments on commit 652a9ca

Please sign in to comment.