Fix syntax error in test

github · Aug 21, 2024 · 3552936 · 3552936
1 parent 6231211
commit 3552936
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/go/ql/test/library-tests/semmle/go/Function/genericFunctions.go b/go/ql/test/library-tests/semmle/go/Function/genericFunctions.go
@@ -72,12 +72,18 @@ func generic_functions() {
 	// Slice write
 	sliceVar[0] = -1
 
-	// Access a map through two type aliases
-	aliasedMap := T2{"key": []string{"value"}}
+	// Access a map through two named types
+	mapThroughNamedTypes := DefinedType2{"key": []string{"value"}}
 	// Map read
-	_ = aliasedMap["key"]
+	_ = mapThroughNamedTypes["key"]
 	// Map write
-	aliasedMap["key"][0] = "new value"
+	mapThroughNamedTypes["key"][0] = "new value"
+	// Access a map through two type aliases and two named types
+	mapThroughAliasedTypes := AliasType2{"key": []string{"value"}}
+	// Map read
+	_ = mapThroughAliasedTypes["key"]
+	// Map write
+	mapThroughAliasedTypes["key"][0] = "new value"
 }
 
 type GenericStruct1[TP104 interface{}] struct {

diff --git a/go/ql/test/library-tests/semmle/go/Types/Aliases.ql b/go/ql/test/library-tests/semmle/go/Types/Aliases.ql
@@ -4,6 +4,8 @@ string getQualifiedNameIfExists(Type t) {
   if exists(t.getQualifiedName()) then result = t.getQualifiedName() else result = t.getName()
 }
 
+predicate foo(Type t, string s) { not exists(t.getQualifiedName()) and s = t.pp() }
+
 from AliasType at
 where at.hasLocationInfo(_, _, _, _, _)
 select getQualifiedNameIfExists(at), getQualifiedNameIfExists(at.getRhs()),