Skip to content

Commit

Permalink
Merge pull request #17748 from owen-mc/go/join-order-fix/data-flow-no…
Browse files Browse the repository at this point in the history
…de-gettype

Go: Fix bad join order in `SummarizedParameterNode.gettype`
  • Loading branch information
owen-mc authored Oct 15, 2024
2 parents 7d9a3e1 + 1456ec2 commit 1626af0
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion go/ql/lib/semmle/go/dataflow/internal/DataFlowNodes.qll
Original file line number Diff line number Diff line change
Expand Up @@ -727,7 +727,10 @@ module Public {
override string getNodeKind() { result = "external parameter node" }

override Type getType() {
result = this.getSummarizedCallable().getType().getParameterType(this.getPos())
result =
this.getSummarizedCallable()
.getType()
.getParameterType(pragma[only_bind_into](this.getPos()))
or
this.getPos() = -1 and
result = this.getSummarizedCallable().asFunction().(Method).getReceiverType()
Expand Down

0 comments on commit 1626af0

Please sign in to comment.