Merge pull request #14265 from phillmv/patch-1

s/Replace/ReplaceAll/ in LogInjectionGood.go
github · Sep 20, 2023 · 07dbad5 · 07dbad5
2 parents 8e864ab + a8afa05
commit 07dbad5
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/go/ql/src/Security/CWE-117/LogInjectionGood.go b/go/ql/src/Security/CWE-117/LogInjectionGood.go
@@ -9,7 +9,7 @@ import (
 // GOOD: The user-provided value is escaped before being written to the log.
 func handlerGood(req *http.Request) {
 	username := req.URL.Query()["username"][0]
-	escapedUsername := strings.Replace(username, "\n", "", -1)
-	escapedUsername = strings.Replace(escapedUsername, "\r", "", -1)
+	escapedUsername := strings.ReplaceAll(username, "\n", "")
+	escapedUsername = strings.ReplaceAll(escapedUsername, "\r", "")
 	log.Printf("user %s logged in.\n", escapedUsername)
 }