Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow improvement #43

Merged
merged 12 commits into from
Nov 7, 2024
Merged

Flow improvement #43

merged 12 commits into from
Nov 7, 2024

Conversation

mrbojangles3
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Oct 30, 2024

🚀 Deployed on https://preview-43--hedgehog-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request October 30, 2024 20:03 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 30, 2024 20:49 Inactive
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean-up looks good to me, with a few nits here and there.

docs/vlab/demo.md Show resolved Hide resolved
docs/vlab/running.md Outdated Show resolved Hide resolved
docs/vlab/overview.md Outdated Show resolved Hide resolved
docs/vlab/overview.md Outdated Show resolved Hide resolved
docs/vlab/running.md Outdated Show resolved Hide resolved
docs/vlab/running.md Outdated Show resolved Hide resolved
docs/vlab/running.md Outdated Show resolved Hide resolved
Co-authored-by: Quentin Monnet <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request October 31, 2024 14:59 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2024 15:00 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2024 15:19 Inactive
@mrbojangles3 mrbojangles3 requested a review from qmonnet October 31, 2024 17:41
@github-actions github-actions bot temporarily deployed to pull request October 31, 2024 17:42 Inactive
@github-actions github-actions bot temporarily deployed to pull request October 31, 2024 17:42 Inactive
docs/vlab/demo.md Show resolved Hide resolved
docs/vlab/overview.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 1, 2024 19:54 Inactive
docs/vlab/overview.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request November 4, 2024 18:28 Inactive
docs/vlab/overview.md Outdated Show resolved Hide resolved
@qmonnet
Copy link
Member

qmonnet commented Nov 5, 2024

Side note: I'd recommend clicking the “re-request review” button once you've addressed feedback from a reviewer. In my case at least, this sends the PR back into my watchlist of assigned reviews.

Co-authored-by: Quentin Monnet <[email protected]>
@github-actions github-actions bot temporarily deployed to pull request November 5, 2024 15:12 Inactive
@mrbojangles3 mrbojangles3 requested a review from qmonnet November 5, 2024 15:23
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

Once logged in, download and run the script:

```bash
curl -fsSL https://i.hhdev.io/hhfab | bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note, we may have to change this domain in the future (https://every.to/p/the-disappearance-of-an-internet-domain).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we're good for a few years with it, but that's a danger of ccTLDs :(

@Frostman Frostman merged commit 65065ff into master Nov 7, 2024
2 checks passed
@Frostman Frostman deleted the flow_improvement branch November 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants