Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitar] Cleaning up stale flag: projectListImprovements with value true #1699

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

gitar-bot[bot]
Copy link

@gitar-bot gitar-bot bot commented Dec 17, 2024

Gitar
This automated PR permanently enables the projectListImprovements feature flag.

Summary of Changes

Gitar found and removed uses or definitions of the projectListImprovements feature flag across 6 files. Some of these files include:

  • frontend/src/component/project/ProjectCard/ProjectCardFooter/ProjectCardFooter.tsx
  • frontend/src/component/project/ProjectCard/ProjectModeBadge/ProjectModeBadge.tsx
  • frontend/src/component/project/ProjectList/ProjectList.tsx
  • frontend/src/interfaces/uiConfig.ts
  • src/lib/types/experimental.ts

Gitar performed deep cleanup and code optimizations triggered by the feature flag removal in 4 of these files.

Code Cleanup Details
  • frontend/src/component/project/ProjectCard/ProjectCardFooter/ProjectCardFooter.tsx

    • Replaced Feature Flag Usage
    • Cleaned up code (3 times)
      • Propagated the value true to uses of the variable projectListImprovementsEnabled
      • Simplified control flow
      • Simplified boolean expressions
  • frontend/src/component/project/ProjectCard/ProjectModeBadge/ProjectModeBadge.tsx

    • Replaced Feature Flag Usage
    • Cleaned up code (6 times)
      • Propagated the value true to uses of the variable projectListImprovementsEnabled (2 times)
      • Simplified control flow (4 times)
  • frontend/src/component/project/ProjectList/ProjectGroup.tsx

    • Replaced Feature Flag Usage
    • Cleaned up code (4 times)
      • Propagated the value true to uses of the variable projectListImprovementsEnabled (2 times)
      • Simplified control flow
      • Simplified boolean expressions
  • frontend/src/component/project/ProjectList/ProjectList.tsx

    • Replaced Feature Flag Usage
    • Cleaned up code (3 times)
      • Propagated the value true to uses of the variable projectListImprovementsEnabled
      • Simplified control flow (2 times)
  • frontend/src/interfaces/uiConfig.ts

    • Removed Feature Flag Definition
  • src/lib/types/experimental.ts

    • Removed Feature Flag Definition
Details

Triggered via #1697 (comment) by @Kakapio


This automated PR was generated by Gitar. View docs.

@gitar-bot gitar-bot bot force-pushed the gitar_projectListImprovements_true branch from 0ec2a4b to 873732d Compare December 17, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants