Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gitar] Cleaning up stale flag: stripHeadersOnAPI with value false #1684

Closed
wants to merge 10 commits into from

Conversation

gitar-bot-staging[bot]
Copy link

Gitar

Details

Triggered via #1683 (comment) by @naveenOnarayanan


This automated PR was generated by Gitar. View docs.

Comment on lines -89 to -123
const apiHelmet = helmet({
hsts: {
maxAge: hoursToSeconds(24 * 365 * 2), // 2 non-leap years
includeSubDomains: true,
preload: true,
},
contentSecurityPolicy: {
directives: {
defaultSrc:
helmet.contentSecurityPolicy
.dangerouslyDisableDefaultSrc,
fontSrc: null,
styleSrc: null,
scriptSrc: null,
imgSrc: null,
connectSrc: null,
mediaSrc: null,
objectSrc: null,
frameSrc: null,
upgradeInsecureRequests: null,
scriptSrcAttr: null,
baseUri: null,
formAction: null,
frameAncestors: ["'none'"],
},
},

crossOriginEmbedderPolicy: false,
crossOriginResourcePolicy: false,
crossOriginOpenerPolicy: false,
originAgentCluster: false,
xXssProtection: false,
xDnsPrefetchControl: false,
xFrameOptions: { action: 'deny' },
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staging @gitar-bot /skip-cleanup apiHelmet

@@ -25,7 +25,6 @@ export type IFlagKey =
| 'advancedPlayground'
| 'filterInvalidClientMetrics'
| 'disableMetrics'
| 'stripHeadersOnAPI'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

staging @gitar-bot /skip-cleanup stripHeadersOnAPI

@naveenOnarayanan naveenOnarayanan deleted the gitar_stripHeadersOnAPI_false branch September 18, 2024 02:52
@naveenOnarayanan
Copy link

staging @gitar-bot cleanup stripHeadersOnAPI=false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant