[Gitar] Cleaning up stale flag: signals with value false

frontend/src/component/integrations/IntegrationList/AvailableIntegrations/AvailableIntegrations.tsx

@@ -6,9 +6,6 @@ import { JIRA_INFO } from '../../ViewIntegration/JiraIntegration/JiraIntegration
 import { StyledCardsGrid } from '../IntegrationList.styles';
 import { RequestIntegrationCard } from '../RequestIntegrationCard/RequestIntegrationCard';
 import { OFFICIAL_SDKS } from './SDKs';
-import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
-import { useUiFlag } from 'hooks/useUiFlag';
-import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
 
 interface IAvailableIntegrationsProps {
     providers: AddonTypeSchema[];
@@ -54,9 +51,6 @@ const StyledGrayContainer = styled('div')(({ theme }) => ({
 export const AvailableIntegrations: VFC<IAvailableIntegrationsProps> = ({
     providers,
 }) => {
-    const { isEnterprise } = useUiConfig();
-    const signalsEnabled = useUiFlag('signals');
-
     const customProviders = [JIRA_INFO];
     const serverSdks = OFFICIAL_SDKS.filter((sdk) => sdk.type === 'server');
     const clientSdks = OFFICIAL_SDKS.filter((sdk) => sdk.type === 'client');
@@ -97,17 +91,6 @@ export const AvailableIntegrations: VFC<IAvailableIntegrationsProps> = ({
                                 />
                             ),
                         )}
-                    <ConditionallyRender
-                        condition={isEnterprise() && signalsEnabled}
-                        show={
-                            <IntegrationCard
-                                icon='signals'
-                                title='Signals'
-                                description='Signal endpoints allow third-party services to send signals to Unleash.'
-                                link='/integrations/signals'
-                            />
-                        }
-                    />
                     {/* TODO: sort providers from backend with custom providers */}
                     {customProviders?.map(
                         ({ name, displayName, description }) => (

frontend/src/component/integrations/IntegrationList/ConfiguredIntegrations/ConfiguredIntegrations.tsx

@@ -4,10 +4,6 @@ import { StyledCardsGrid } from '../IntegrationList.styles';
 import { IntegrationCard } from '../IntegrationCard/IntegrationCard';
 import type { VFC } from 'react';
 import { Typography, styled } from '@mui/material';
-import { useSignalEndpoints } from 'hooks/api/getters/useSignalEndpoints/useSignalEndpoints';
-import { useUiFlag } from 'hooks/useUiFlag';
-import { ConditionallyRender } from 'component/common/ConditionallyRender/ConditionallyRender';
-import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
 
 const StyledConfiguredSection = styled('section')(({ theme }) => ({
     display: 'flex',
@@ -27,10 +23,6 @@ export const ConfiguredIntegrations: VFC<ConfiguredIntegrationsProps> = ({
     addons,
     providers,
 }) => {
-    const { signalEndpoints } = useSignalEndpoints();
-    const signalsEnabled = useUiFlag('signals');
-    const { isEnterprise } = useUiConfig();
-
     const ref = useLoading(loading || false);
 
     return (
@@ -73,27 +65,6 @@ export const ConfiguredIntegrations: VFC<ConfiguredIntegrationsProps> = ({
                             />
                         );
                     })}
-                <ConditionallyRender
-                    condition={
-                        isEnterprise() &&
-                        signalsEnabled &&
-                        signalEndpoints.length > 0
-                    }
-                    show={
-                        <IntegrationCard
-                            variant='stacked'
-                            icon='signals'
-                            title='Signals'
-                            description={`${
-                                signalEndpoints.length
-                            } signal endpoint${
-                                signalEndpoints.length === 1 ? '' : 's'
-                            } configured`}
-                            link='/integrations/signals'
-                            configureActionText='View signal endpoints'
-                        />
-                    }
-                />
             </StyledCardsGrid>
         </StyledConfiguredSection>
     );

frontend/src/component/layout/MainLayout/NavigationSidebar/NewInUnleash/NewInUnleash.tsx

@@ -1,6 +1,4 @@
 import type { ReactNode } from 'react';
-import { useUiFlag } from 'hooks/useUiFlag';
-import useUiConfig from 'hooks/api/getters/useUiConfig/useUiConfig';
 import { useLocalStorageState } from 'hooks/useLocalStorageState';
 import {
     Badge,
@@ -86,16 +84,13 @@ interface INewInUnleashProps {
 
 export const NewInUnleash = ({
     mode = 'full',
-    onItemClick,
     onMiniModeClick,
 }: INewInUnleashProps) => {
     const { trackEvent } = usePlausibleTracker();
     const [seenItems, setSeenItems] = useLocalStorageState(
         'new-in-unleash-seen:v1',
         new Set(),
     );
-    const { isEnterprise } = useUiConfig();
-    const signalsEnabled = useUiFlag('signals');
 
     const items: NewItem[] = [
         {
@@ -105,7 +100,7 @@ export const NewInUnleash = ({
             preview: <SignalsPreview />,
             link: '/integrations/signals',
             docsLink: 'https://docs.getunleash.io/reference/signals',
-            show: isEnterprise() && signalsEnabled,
+            show: false,
             longDescription: (
                 <>
                     <p>

frontend/src/hooks/api/getters/useSignalEndpointSignals/useSignalEndpointSignals.ts

@@ -2,13 +2,8 @@ import useSWRInfinite, {
     type SWRInfiniteConfiguration,
     type SWRInfiniteKeyLoader,
 } from 'swr/infinite';
-import { formatApiPath } from 'utils/formatPath';
 import handleErrorResponses from '../httpErrorResponseHandler';
-import useUiConfig from '../useUiConfig/useUiConfig';
 import type { ISignalEndpointSignal } from 'interfaces/signal';
-import { useUiFlag } from 'hooks/useUiFlag';
-
-const ENDPOINT = 'api/admin/signal-endpoints';
 
 type SignalsResponse = {
     signalEndpointSignals: ISignalEndpointSignal[];
@@ -25,25 +20,12 @@ export const useSignalEndpointSignals = (
     limit = 50,
     options: SWRInfiniteConfiguration = {},
 ) => {
-    const { isEnterprise } = useUiConfig();
-    const signalsEnabled = useUiFlag('signals');
-
     const getKey: SWRInfiniteKeyLoader = (
         pageIndex: number,
         previousPageData: SignalsResponse,
     ) => {
         // Does not meet conditions
-        if (!signalEndpointId || !isEnterprise || !signalsEnabled) return null;
-
-        // Reached the end
-        if (previousPageData && !previousPageData.signalEndpointSignals.length)
-            return null;
-
-        return formatApiPath(
-            `${ENDPOINT}/${signalEndpointId}/signals?limit=${limit}&offset=${
-                pageIndex * limit
-            }`,
-        );
+        return null;
     };
 
     const { data, error, size, setSize, mutate } =

frontend/src/hooks/api/getters/useSignalEndpointTokens/useSignalEndpointTokens.ts

@@ -2,9 +2,7 @@ import { useMemo } from 'react';
 import { formatApiPath } from 'utils/formatPath';
 import handleErrorResponses from '../httpErrorResponseHandler';
 import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';
-import useUiConfig from '../useUiConfig/useUiConfig';
 import type { ISignalEndpointToken } from 'interfaces/signal';
-import { useUiFlag } from 'hooks/useUiFlag';
 
 const ENDPOINT = 'api/admin/signal-endpoints';
 
@@ -13,13 +11,10 @@ const DEFAULT_DATA = {
 };
 
 export const useSignalEndpointTokens = (signalEndpointId: number) => {
-    const { isEnterprise } = useUiConfig();
-    const signalsEnabled = useUiFlag('signals');
-
     const { data, error, mutate } = useConditionalSWR<{
         signalEndpointTokens: ISignalEndpointToken[];
     }>(
-        isEnterprise() && signalsEnabled,
+        false,
         DEFAULT_DATA,
         formatApiPath(`${ENDPOINT}/${signalEndpointId}/tokens`),
         fetcher,

frontend/src/hooks/api/getters/useSignalEndpoints/useSignalEndpoints.ts

@@ -2,10 +2,7 @@ import { useContext, useMemo } from 'react';
 import { formatApiPath } from 'utils/formatPath';
 import handleErrorResponses from '../httpErrorResponseHandler';
 import { useConditionalSWR } from '../useConditionalSWR/useConditionalSWR';
-import useUiConfig from '../useUiConfig/useUiConfig';
 import type { ISignalEndpoint } from 'interfaces/signal';
-import { useUiFlag } from 'hooks/useUiFlag';
-import AccessContext from 'contexts/AccessContext';
 
 const ENDPOINT = 'api/admin/signal-endpoints';
 
@@ -14,18 +11,9 @@ const DEFAULT_DATA = {
 };
 
 export const useSignalEndpoints = () => {
-    const { isAdmin } = useContext(AccessContext);
-    const { isEnterprise } = useUiConfig();
-    const signalsEnabled = useUiFlag('signals');
-
     const { data, error, mutate } = useConditionalSWR<{
         signalEndpoints: ISignalEndpoint[];
-    }>(
-        isEnterprise() && isAdmin && signalsEnabled,
-        DEFAULT_DATA,
-        formatApiPath(ENDPOINT),
-        fetcher,
-    );
+    }>(false, DEFAULT_DATA, formatApiPath(ENDPOINT), fetcher);
 
     return useMemo(
         () => ({

frontend/src/interfaces/uiConfig.ts

@@ -66,7 +66,6 @@ export type UiFlags = {
     doraMetrics?: boolean;
     dependentFeatures?: boolean;
     newStrategyConfiguration?: boolean;
-    signals?: boolean;
     automatedActions?: boolean;
     celebrateUnleash?: boolean;
     featureSearchFeedback?: Variant;

src/lib/types/experimental.ts

@@ -26,7 +26,6 @@ export type IFlagKey =
     | 'filterInvalidClientMetrics'
     | 'disableMetrics'
     | 'stripHeadersOnAPI'
-    | 'signals'
     | 'automatedActions'
     | 'celebrateUnleash'
     | 'featureSearchFeedback'
@@ -137,10 +136,6 @@ const flags: IFlags = {
         process.env.UNLEASH_EXPERIMENTAL_DISABLE_METRICS,
         false,
     ),
-    signals: parseEnvVarBoolean(
-        process.env.UNLEASH_EXPERIMENTAL_SIGNALS,
-        false,
-    ),
     automatedActions: parseEnvVarBoolean(
         process.env.UNLEASH_EXPERIMENTAL_AUTOMATED_ACTIONS,
         false,