Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

define vendor key for added metadata #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lrvick
Copy link

@lrvick lrvick commented Oct 7, 2018

So I feel we need an added statement to add a compromise for #10

I know many orgs will have extra metadata they want to sign as part of automation or general evidence etc. Maybe an org wants to include their CI job ID, or has their own review format. Maybe they already use something like Google's git-appraise and want to be able to include hashes of their detailed review blobs from the refs/notes/devtools/reviews ref in their git/refs/signatures. Maybe they want to include ticket numbers from their internal issue system etc.

I don't think we should stop people from including data they feel is valuable to show context around a change, but we should regulate that it goes somewhere that the spec won't ever interpret.

I suggest we include a vendor key to allow for use cases we can't think of yet.

E.g. make new pre-spec git-signatures features use the: ""vendor: { git-signatures:{} }" namespace

@Ekleog
Copy link
Contributor

Ekleog commented Oct 8, 2018

Hmm… any reason not to have these vendor-specific data go into the review message?

@oxij
Copy link
Member

oxij commented Oct 8, 2018

This feels like "User-Agent" field. I think #10 (comment) is a better approach.

@Ekleog
Copy link
Contributor

Ekleog commented Oct 25, 2018

This is blocked on #4 / #10

@Ekleog Ekleog added the blocked Blocked on another issue label Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants