Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnupg: update to 2.4.4 #149

Merged
merged 1 commit into from
Feb 3, 2024
Merged

gnupg: update to 2.4.4 #149

merged 1 commit into from
Feb 3, 2024

Conversation

gitforwindowshelper[bot]
Copy link

The first patch needed adapting, and the third one (which was a
backport) is no longer needed.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho dscho marked this pull request as ready for review January 28, 2024 19:47
@dscho
Copy link
Member

dscho commented Jan 28, 2024

@rimrul I performed some light testing with the version built in https://github.com/git-for-windows/MSYS2-packages/actions/runs/7673593687?pr=149, and it seems that everything is working as expected. Would you mind adding your own testing? Then we might be able to include this GnuPG version in Git for Windows v2.44 (which is due on or short after February 19th).

@dscho
Copy link
Member

dscho commented Feb 3, 2024

I ran with this for the last couple of days and did not even realize that it was the new version until I stumbled back over this here PR and thought I'd check. So I think we're good to go.

@dscho
Copy link
Member

dscho commented Feb 3, 2024

/deploy

The x86_64 and the i686 workflow runs were started.

dscho added a commit that referenced this pull request Feb 3, 2024
I just ran into the undesirable situation where a `/deploy` failed in
the i686 flavor even after the CI build succeeded:
#149 (comment)

The reason was an outdated dependency in git-sdk-32.

To detect these situations better _before_ issuing `/deploy`, let's just
include the i686 flavor in the CI builds.

Obviously we have to exclude `msys2-runtime` from being built on i686
because it has dropped support for 32-bit since v3.4.0.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member

dscho commented Feb 3, 2024

😞 image

The reason is this:

*** You need libksba to build this program.
*** This library is for example available at
*** https://gnupg.org/ftp/gcrypt/libksba/
*** (at least version 1.6.3 using API 1 is required).

And git-sdk-32 only has v1.6.0 of this library. So I'll try building and deploying a newer version of that package over in #153 before re-running the failed job.

@dscho
Copy link
Member

dscho commented Feb 3, 2024

image

🎉

@dscho dscho merged commit 4f0d967 into main Feb 3, 2024
5 checks passed
@dscho dscho deleted the gnupg-2.4.4 branch February 3, 2024 14:29
@dscho dscho self-assigned this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New gpg version] gnupg-2.4.4
1 participant