Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "Add assignee to PR" workflow #9

Closed
wants to merge 1 commit into from
Closed

Conversation

masutaka
Copy link
Member

@masutaka masutaka commented Oct 4, 2024

Summary

Introduce the reusable workflow route06/actions/.github/workflows/add_assignee_to_pr.yml

Related Issue

Nothing

Changes

Create .github/workflows/add_assignee_to_pr.yml. This workflow was added to route06inc/template by route06inc/template#3

Testing


It works well.

Other Information

Nothing

@masutaka masutaka marked this pull request as ready for review October 4, 2024 02:35
@masutaka masutaka requested a review from a team as a code owner October 4, 2024 02:35
@masutaka masutaka requested review from toyamarinyon, shige and koji-m and removed request for a team October 4, 2024 02:35
Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to minimize the number of GitHub Actions that are run. What are the benefits of enforcing author assignment on pull requests?

Looking at OSS GitHub repositories, it's more common to see pull requests without assigned authors. For example:

Could you explain the reasoning behind this requirement?

@masutaka
Copy link
Member Author

masutaka commented Oct 7, 2024

@toyamarinyon I just followed the convention of ROUTE06 and did not think too deeply about it.
If there is an advantage, it is that it may be used for data analysis in the future when the number of OSS repositories grows.

@masutaka
Copy link
Member Author

@toyamarinyon @shige
I have no strong opinion on this PR. 👀
Toyama-san do not want to increase the number of GitHub Actions, and if there are no other requests, I will close this PR next week.

@shige
Copy link
Member

shige commented Oct 18, 2024

@masutaka @toyamarinyon It doesn't matter whether I'm here or not, so let's close it now.

@masutaka masutaka closed this Oct 18, 2024
@masutaka masutaka deleted the add_assignee_to_pr branch October 18, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants