Check the trigger of License Finder #55
Closed
+1,219
−247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add v2 connector actions and reducer for state management - Create connector utilities for building standardized connector objects - Integrate connectors with React Flow edges in the graph editor - Deprecate old addConnector implementation in favor of v2 system - Update node connection logic to use the new v2 connector system
- Add selection state synchronization between React Flow and internal node UI state - Update node UI state when selection changes occur in React Flow - Handle selection changes through the existing updateNodesUI action
- Remove explicit node click and pane click selection handlers - Update GiselleNode to receive selection state directly from React Flow - Add position syncing from React Flow to internal node state - Remove unused deleteKeyCode prop from ReactFlow component
- Add edge change handler for React Flow integration - Implement removeConnector action for handling edge deletion - Add removeSource action to clean up related nodes and connections - Add cascade deletion logic for instruction nodes and their connections - Update editor to handle edge change events - Add type safety improvements for React Flow generic types
- Add setNodes action for batch node updates - Implement node removal handler in React Flow adapter - Sync node deletion between React Flow and internal state - Add type definitions for new node actions
- Replace addNode action with setNodes for consistency - Remove redundant addNode action type and reducer case - Update addNode composite action to use setNodes - Simplify node action types by consolidating state updates
- Move node action types and reducer from graph/v2/node to giselle-node/actions - Update imports across codebase to use new location - Remove duplicate node action definitions - Clean up file organization for better domain separation - Delete deprecated graph/v2/node.ts file
- Create updateNode composite action for synchronized state updates - Add support for updating node properties and parameters - Sync updates between internal state and React Flow nodes - Migrate addSourceToPromptNode to use v2 actions for consistency - Improve type safety with structured input interface
- Create removeSource composition action to handle clean source removal - Update PromptPropertyPanel to use new removeSource action - Replace updateNodeProperty with v2 updateNode action - Replace removeParameterFromNode with v2 node update - Add parameter property filtering for clean parameter removal - Add additional error handling and type safety checks
- Update source addition logic in prompt panel to use new addSource action - Temporarily disable connector and node updates in removeSource function - Clean up variable naming in removeSource for better clarity
- Enhance removeConnector logic: - Add XY flow edge cleanup - Make connector removal more resilient to missing connectors - Refactor removeSource function: - Re-enable node and connector updates - Use removeConnector action for cleaner state management - Improve error handling for missing source connectors - Better variable naming for clarity
- Introduce `removeSourcesConnected` function for better modularity - Add `ConnectorObject` type for more precise connector handling - Replace internal logic to use input parameter for connector details - Remove redundant error handling for missing instruction and source This refactor improves code readability and maintainability by organizing the logic for source removal within a separate function. No breaking changes were introduced.
- Introduce `removeSourcesConnected` function for better modularity - Add `ConnectorObject` type for more precise connector handling - Replace internal logic to use input parameter for connector details - Remove redundant error handling for missing instruction and source
- Integrate node state updates in `addConnector` function - Remove redundant node state logic from `addSource` - Ensure proper handling of final states for source and target nodes
- Implement an additional action to update the final flag - Adjust node handling during the connector removal process - Modify state management for better handling of node changes
- Add additional check to ensure the source node category is an action - Enhance the logic for updating the final flag during connector removal
- Streamline the process of adding and connecting nodes - Update UI state to toggle selected nodes properly - Introduce handling for partial UI updates in node modification
- Replace existing addSourceToPromptNode and removeSourceFromPromptNode with centralized addSource and removeSource functions to streamline the source management process. - Update source management to support new input structure and error handling, enhancing maintainability and consistency across modules.
- Refactor text generation logic by introducing createGenerateTextAction, which consolidates updates to selected nodes and outgoing connections into a single action, improving code clarity and maintainability. - Update existing button click handler to utilize this new action, reducing redundancy and streamlining the text generation process.
- Simplify the mouse enter and leave event handlers - Change the update function to target individual nodes instead of updating all at once, improving performance and responsiveness
- Refactor how graph data is processed and passed to React Flow by centralizing the logic in `graphToReactFlow` function. This reduces code duplication and enhances clarity around graph data structure. - Introduce logging to assist with debugging graph properties during development.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Changes
Testing
Other Information