Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to resolve unintended git diffs before PR review #46

Merged
merged 8 commits into from
Oct 24, 2024
Merged

Conversation

Rindrics
Copy link
Contributor

@Rindrics Rindrics commented Oct 24, 2024

Summary

  • Avoid accumulation of small problems by setting up CI

Related Issue

Changes

  • added GitHub Action workflow to detect uncomitted diff

Testing

the workflow detected bad diffs on codebase

the workflow succeeded when codebase become healthy

https://github.com/route06inc/giselle/actions/runs/11493035334

Other Information

Copy link

vercel bot commented Oct 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 5:26am

Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Rindrics
Copy link
Contributor Author

thx!

@Rindrics Rindrics merged commit a96e9db into main Oct 24, 2024
8 checks passed
@Rindrics Rindrics deleted the add-ci branch October 24, 2024 05:41
Comment on lines +16 to +17
- name: Install dependencies
run: bun install
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked that it has been replaced by #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup CI to avoid accumulation of small problems
3 participants