-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Viewer mode and isFinal flag to prepare for flow execution #43
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@toyamarinyon Let me know 👂 When is it expected that the VIEW mode and the Run button will become available? |
@shige I understand your point. While we could hide these features behind a Feature Flag, since these changes don't affect terms of service or privacy policy, I think it might be acceptable to show features that are still under development. |
@toyamarinyon |
@shige I understand. However, if we wait until everything is fully functional, the diff will become quite large. So I'll implement a Feature Flag to disable these features, which will allow us to merge now. |
I agree. 👍 |
@shige Could you verify these changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Tomorrow morning, I'll deploy them and migrate db data. 📆
Done! $ bun scripts/20241023-db-patch-finalv2.ts
Starting the update of agent data to set 'isFinal' property on nodes.
Updating 72 agents...
├ Processing chunk 1/8 (10 agents)
│ └ Completed chunk 1/8
├ Processing chunk 2/8 (10 agents)
│ └ Completed chunk 2/8
├ Processing chunk 3/8 (10 agents)
│ └ Completed chunk 3/8
├ Processing chunk 4/8 (10 agents)
│ └ Completed chunk 4/8
├ Processing chunk 5/8 (10 agents)
│ └ Completed chunk 5/8
├ Processing chunk 6/8 (10 agents)
│ └ Completed chunk 6/8
├ Processing chunk 7/8 (10 agents)
│ └ Completed chunk 7/8
├ Processing chunk 8/8 (2 agents)
│ └ Completed chunk 8/8
All agents have been successfully updated! |
All done ✅
JFYI @toyamarinyon |
Overview
Added initial preparation for flow execution functionality in Playground.
Changes
isFinal
flag to nodes to identify terminal nodes in the flowDetails
Previously, Playground only had Editor functionality without a way to view flow execution results. This PR adds a basic Viewer component structure (currently empty) and the ability to switch between Editor and Viewer modes.
Additionally, introduced an
isFinal
flag to nodes to help identify which nodes represent the end of a flow, which will be necessary for proper flow execution.Release Flow:
Since this includes database migrations, please merge and run the script
./scripts/20241023-db-patch-finalv2.ts
after approval.