Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Viewer mode and isFinal flag to prepare for flow execution #43

Merged
merged 10 commits into from
Oct 24, 2024

Conversation

toyamarinyon
Copy link
Contributor

Overview

Added initial preparation for flow execution functionality in Playground.

Changes

  • Added Viewer component alongside existing Editor
  • Implemented mode switching between Editor and Viewer
  • Added isFinal flag to nodes to identify terminal nodes in the flow

Details

Previously, Playground only had Editor functionality without a way to view flow execution results. This PR adds a basic Viewer component structure (currently empty) and the ability to switch between Editor and Viewer modes.

Additionally, introduced an isFinal flag to nodes to help identify which nodes represent the end of a flow, which will be necessary for proper flow execution.

Release Flow:

Since this includes database migrations, please merge and run the script ./scripts/20241023-db-patch-finalv2.ts after approval.

@toyamarinyon toyamarinyon requested a review from shige as a code owner October 23, 2024 06:51
Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2024 0:24am

@shige shige added the enhancement New feature or request label Oct 23, 2024
@shige
Copy link
Member

shige commented Oct 23, 2024

@toyamarinyon Let me know 👂

When is it expected that the VIEW mode and the Run button will become available?
If we merge this now, it will release features that are not yet usable, which I believe will cause confusion among existing users.

@toyamarinyon
Copy link
Contributor Author

@shige I understand your point. While we could hide these features behind a Feature Flag, since these changes don't affect terms of service or privacy policy, I think it might be acceptable to show features that are still under development.

@shige
Copy link
Member

shige commented Oct 23, 2024

@toyamarinyon
What I meant was that we can't release something that simply doesn't work.
Once the VIEW Mode and RUN button are working, we will merge and deploy, so please let me know.

@toyamarinyon
Copy link
Contributor Author

@shige I understand. However, if we wait until everything is fully functional, the diff will become quite large. So I'll implement a Feature Flag to disable these features, which will allow us to merge now.

@shige
Copy link
Member

shige commented Oct 23, 2024

I agree. 👍

@toyamarinyon
Copy link
Contributor Author

I've disabled the VIEW mode toggle and Run button by default using the Feature Flag. These elements will not be displayed when the Feature Flag is turned off (default state).

Default

image

Override

image

@toyamarinyon
Copy link
Contributor Author

@shige Could you verify these changes?

Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tomorrow morning, I'll deploy them and migrate db data. 📆

@shige shige merged commit 167c708 into main Oct 24, 2024
7 checks passed
@shige shige deleted the final-node-for-each-flow branch October 24, 2024 00:36
@shige
Copy link
Member

shige commented Oct 24, 2024

Tomorrow morning, I'll deploy them and migrate db data. 📆

Done!

$ bun scripts/20241023-db-patch-finalv2.ts

Starting the update of agent data to set 'isFinal' property on nodes.
Updating 72 agents...
  ├ Processing chunk 1/8 (10 agents)
  │ └ Completed chunk 1/8
  ├ Processing chunk 2/8 (10 agents)
  │ └ Completed chunk 2/8
  ├ Processing chunk 3/8 (10 agents)
  │ └ Completed chunk 3/8
  ├ Processing chunk 4/8 (10 agents)
  │ └ Completed chunk 4/8
  ├ Processing chunk 5/8 (10 agents)
  │ └ Completed chunk 5/8
  ├ Processing chunk 6/8 (10 agents)
  │ └ Completed chunk 6/8
  ├ Processing chunk 7/8 (10 agents)
  │ └ Completed chunk 7/8
  ├ Processing chunk 8/8 (2 agents)
  │ └ Completed chunk 8/8
All agents have been successfully updated!

@shige
Copy link
Member

shige commented Oct 24, 2024

All done ✅

  • deployed to production
  • migrated db data
  • confirmed the operation

JFYI @toyamarinyon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants