Avoid error on "verify-email" page under browser auto-translation #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid error on DOM manipulation otherwise we'll get error below: > NotFoundError: Failed to execute 'removeChild' on 'Node': The node > to be removed is not a child of this node.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rindrics
changed the title
There was a problem hiding this comment.
Please add a comment to describe the "notranslate" class that will prevent Chrome's translation feature. No class name provided tailwindcss
You can now add class="notranslate" to any HTML element to prevent that element from being translated. For example, you may want to do something like:
https://developers.google.com/search/blog/2008/10/helping-you-break-language-barrier
yeah you're right. fixed: https://github.com/route06inc/giselle/pull/42/commits/c8dd9b674a429e9385f0a83f881c3567f46d8c64txyo |
toyamarinyon
approved these changes
Oct 23, 2024
|
thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable signing up in environment with browser auto-translation by preventing unintended change in element class of OTP field
Related Issue
Changes
Disallow translation on OTP "field" on /signup/verify-email
/signup/verify-email"page"Testing
bun run devon localOther Information