Enable local font downloads when meeting the required conditions #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to the
package.jsonandprepare-font.jsfiles to improve the development process and add flexibility to the font preparation script.Development Process Improvements:
package.json: Changed thepredevscript to usebuninstead ofnodefor preparing fonts. ([package.jsonL6-R6](https://github.com/giselles-ai/giselle/pull/37/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L6-R6))Flexibility Enhancements:
prepare-font.js: Added a condition to force downloading fonts by checking theFORCE_DOWNLOAD_FONTSenvironment variable. ([prepare-font.jsL24-R27](https://github.com/giselles-ai/giselle/pull/37/files#diff-96a3c889ac24f976a2414d7a3ea85f33e7d6ebc4096881e3b1038b159453c91bL24-R27))Release flow:
The database migration does not exist in these changes. So I'll release it and check it after approval.