Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate the Final Node #36

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Indicate the Final Node #36

merged 6 commits into from
Oct 23, 2024

Conversation

toyamarinyon
Copy link
Contributor

This pull request introduces the concept of a "final node" to the GiselleNode components and related actions in the graph. The changes include updates to the node properties, actions, and reducers to handle the new isFinal property and ensure proper state management.

Updates to GiselleNode components:

Graph actions and reducers:

Database migration:

  • Added a script to update existing nodes in the database to include the isFinal property. (scripts/20241022-db-patch-node-is-final.ts)

Note

The previous scripts lacked details logging, making it difficult to track their execution progress.
The new script outputs details logs, allowing you to clearly monitor the execution status!

❯ bun scripts/20241022-db-patch-node-is-final.ts
Add 'isFinal' to the all of the nodes...
Updating 90 agents...
  ├ Processing chunk 1/9 (10 agents)
  │ └ Completed chunk 1/1
  ├ Processing chunk 2/9 (10 agents)
  │ └ Completed chunk 2/2
  ├ Processing chunk 3/9 (10 agents)
  │ └ Completed chunk 3/3
  ├ Processing chunk 4/9 (10 agents)
  │ └ Completed chunk 4/4
  ├ Processing chunk 5/9 (10 agents)
  │ └ Completed chunk 5/5
  ├ Processing chunk 6/9 (10 agents)
  │ └ Completed chunk 6/6
  ├ Processing chunk 7/9 (10 agents)
  │ └ Completed chunk 7/7
  ├ Processing chunk 8/9 (10 agents)
  │ └ Completed chunk 8/8
  ├ Processing chunk 9/9 (10 agents)
  │ └ Completed chunk 9/9
All agents have been updated!

Release Flow:

Since this includes database migrations, please merge and run the script after approval.

@toyamarinyon toyamarinyon requested a review from shige as a code owner October 22, 2024 06:06
Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 6:06am

@shige shige added the enhancement New feature or request label Oct 22, 2024
Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I'll merge tomorrow morning and run the script for updating db data. 📆

@shige shige merged commit eb35581 into main Oct 23, 2024
7 checks passed
@shige shige deleted the infer-flow branch October 23, 2024 01:02
@shige
Copy link
Member

shige commented Oct 23, 2024

run the script for updating db data. 📆

Done ✅

bun scripts/20241022-db-patch-node-is-final.ts
Add 'isFinal' to the all of the nodes...
Updating 71 agents...
  ├ Processing chunk 1/8 (10 agents)
  │ └ Completed chunk 1/1
  ├ Processing chunk 2/8 (10 agents)
  │ └ Completed chunk 2/2
  ├ Processing chunk 3/8 (10 agents)
  │ └ Completed chunk 3/3
  ├ Processing chunk 4/8 (10 agents)
  │ └ Completed chunk 4/4
  ├ Processing chunk 5/8 (10 agents)
  │ └ Completed chunk 5/5
  ├ Processing chunk 6/8 (10 agents)
  │ └ Completed chunk 6/6
  ├ Processing chunk 7/8 (10 agents)
  │ └ Completed chunk 7/7
  ├ Processing chunk 8/8 (1 agents)
  │ └ Completed chunk 8/8
All agents have been updated!

@shige
Copy link
Member

shige commented Oct 23, 2024

@toyamarinyon All done 🚀

  • Deployed to production.
  • Updated the database data.
  • Completed operation verification in the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants