-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Indicate the Final Node #36
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shige
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I'll merge tomorrow morning and run the script for updating db data. 📆
Done ✅ bun scripts/20241022-db-patch-node-is-final.ts
Add 'isFinal' to the all of the nodes...
Updating 71 agents...
├ Processing chunk 1/8 (10 agents)
│ └ Completed chunk 1/1
├ Processing chunk 2/8 (10 agents)
│ └ Completed chunk 2/2
├ Processing chunk 3/8 (10 agents)
│ └ Completed chunk 3/3
├ Processing chunk 4/8 (10 agents)
│ └ Completed chunk 4/4
├ Processing chunk 5/8 (10 agents)
│ └ Completed chunk 5/5
├ Processing chunk 6/8 (10 agents)
│ └ Completed chunk 6/6
├ Processing chunk 7/8 (10 agents)
│ └ Completed chunk 7/7
├ Processing chunk 8/8 (1 agents)
│ └ Completed chunk 8/8
All agents have been updated! |
@toyamarinyon All done 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces the concept of a "final node" to the GiselleNode components and related actions in the graph. The changes include updates to the node properties, actions, and reducers to handle the new
isFinal
property and ensure proper state management.Updates to GiselleNode components:
GiselleNode
component. (app/(playground)/p/[agentId]/beta-proto/giselle-node/components.tsx
) (app/(playground)/p/[agentId]/beta-proto/giselle-node/components.tsxL135-R136, app/(playground)/p/[agentId]/beta-proto/giselle-node/components.tsxR218)GiselleNode
type to include theisFinal
property. (app/(playground)/p/[agentId]/beta-proto/giselle-node/types.ts
) (app/(playground)/p/[agentId]/beta-proto/giselle-node/types.tsR67)Graph actions and reducers:
addNode
andaddNodesAndConnect
actions to handle theisFinal
property. (app/(playground)/p/[agentId]/beta-proto/graph/actions.ts
) (app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR59, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR72, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR97, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR174-R175, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR184)addSourceToPromptNode
andremoveSourceFromPromptNode
actions to manage the state of final nodes. (app/(playground)/p/[agentId]/beta-proto/graph/actions.ts
) (app/(playground)/p/[agentId]/beta-proto/graph/actions.tsL813-R832, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR896-R917, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR1019-R1039, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR1131-R1154, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsL1102-R1171, app/(playground)/p/[agentId]/beta-proto/graph/actions.tsR1193-R1210)isFinal
property. (app/(playground)/p/[agentId]/beta-proto/graph/actions.ts
,app/(playground)/p/[agentId]/beta-proto/graph/reducer.ts
,app/(playground)/p/[agentId]/beta-proto/graph/v2/node.ts
) (app/(playground)/p/[agentId]/beta-proto/graph/actions.tsL1256-R1344, app/(playground)/p/[agentId]/beta-proto/graph/reducer.tsR3-R17, app/(playground)/p/[agentId]/beta-proto/graph/v2/node.tsR1-R49)Database migration:
isFinal
property. (scripts/20241022-db-patch-node-is-final.ts
)Note
The previous scripts lacked details logging, making it difficult to track their execution progress.
The new script outputs details logs, allowing you to clearly monitor the execution status!
Release Flow:
Since this includes database migrations, please merge and run the script after approval.