Migrate NOTICE.md to License report #32
Merged
+10,295
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@masutaka is attempting to deploy a commit to the Edge team on Vercel, but is not a member of this team. To resolve this issue, you can:
To read more about collaboration on Vercel, click here. |
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
5 times, most recently
from
6962983 to
2a1b57a
Compare
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
from
2a1b57a to
42155d0
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
from
ebf0b84 to
43621b2
Compare
masutaka
changed the title
license_finder permitted_licenses add 'LGPL-3.0-or-later' --why 'To not conflict with Apache-2.0 license. https://opensource.org/license/LGPL-3.0'
$ license_finder permitted_licenses add 'CC0 1.0 Universal' --why 'To not conflict with Apache-2.0 license. https://creativecommons.org/publicdomain/zero/1.0/'
$ license_finder permitted_licenses add 'CC-BY-4.0' --why 'To not conflict with Apache-2.0 license. https://creativecommons.org/licenses/by/4.0/'
masutaka
changed the title
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
from
049b823 to
c69d99d
Compare
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
from
73706d5 to
8d8fc8a
Compare
$ docker run --rm -v $(pwd):/repo --workdir /repo rhysd/actionlint:latest .github/workflows/license.yml:75:211: "github.event.pull_request.head.ref" is potentially untrusted. avoid using it directly in inline scripts. instead, pass it through an environment variable. see https://docs.github.com/en/actions/security-guides/security-hardening-for-github-actions for more details [expression]
masutaka
force-pushed
the
migrate-notice-md-to-license-html-report
branch
from
dba9fbd to
8c79464
Compare
|
Thanks for your review! |
|
✅ Testing on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Up until now, I used to manually put licenses that might need a credit notation in
Notice.md.I added the license report
docs/packages-license.mdand made it auto-update so thatNotice.mdis no longer needed.Also I stopped uploading license reports as artifact.
Related Issue
Nothing
Testing
docs/packages-license.mdwas successfully committed by GitHub Actions.https://github.com/route06inc/giselle/blob/migrate-notice-md-to-license-html-report/docs/packages-license.md
Other Information
CI_TRIGGER_APP_IDCI_TRIGGER_APP_PRIVATE_KEY