Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit for concurrecy ofscraping #31

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Conversation

toyamarinyon
Copy link
Contributor

@toyamarinyon toyamarinyon commented Oct 21, 2024

This pull request includes various enhancements and optimizations to the web search functionality in the app/(playground)/p/[agentId]/beta-proto directory. The most important changes include adding a new relevance field to web search items, optimizing the web search stream processing by chunking items, and increasing the maximum number of search results.

oct21a_output_gif

Enhancements to web search functionality:

Optimizations to web search processing:

Configuration changes:

Code structure improvements:

Release flow:

The database migration does not exist in these changes. So I'll release it and check it after approval.

@toyamarinyon toyamarinyon requested a review from shige as a code owner October 21, 2024 08:17
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 21, 2024 8:17am

@shige shige added the enhancement New feature or request label Oct 21, 2024
Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍


There are cases where it works and cases where it doesn't, so I'd like it to be improved later!

✅ Prompt AI

It works!

❌ Prompt AI agent

I got the errors.

Unhandled Rejection: u [Error]: Vercel Blob: body is required
    at N.allowedOptions (/var/task/.next/server/app/(playground)/p/[agentId]/page.js:94:40864)
    at /var/task/.next/server/app/(playground)/p/[agentId]/page.js:39:2405
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async Promise.all (index 4)
    at async /var/task/.next/server/app/(playground)/p/[agentId]/page.js:39:2267
Node.js process exited with exit status: 128. The logs above can help with debugging the issue.
Unhandled Rejection: t6 [Error]: Unexpected error occurred while trying to scrape URL. Status code: 429
    at t7.handleError (/var/task/.next/server/app/(playground)/p/[agentId]/page.js:94:31789)
    at t7.scrapeUrl (/var/task/.next/server/app/(playground)/p/[agentId]/page.js:94:27878)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async /var/task/.next/server/app/(playground)/p/[agentId]/page.js:39:2323
    at async Promise.all (index 3)
    at async /var/task/.next/server/app/(playground)/p/[agentId]/page.js:39:2267 {
  statusCode: 429
}
Node.js process exited with exit status: 128. The logs above can help with debugging the issue.

Please see vercel logs.

@toyamarinyon
Copy link
Contributor Author

Thanks. Error handling will be implemented in the future.

@toyamarinyon toyamarinyon merged commit 2386cbc into main Oct 21, 2024
7 checks passed
@toyamarinyon toyamarinyon deleted the limit-for-concurrecy-ofscraping branch October 21, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants