Refactor recording & reporting agent time usage #261
+68
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
toyamarinyon
approved these changes
Dec 19, 2024
| currentExecution.durationMs, | ||
| ); | ||
|
|
||
| await onFinishPerformExecution(runEndedAt, totalFlowDurationMs); |
There was a problem hiding this comment.
Suggested change
| await onFinishPerformExecution(runEndedAt, totalFlowDurationMs); | |
| await onFinishPerformExecution?.(runEndedAt, totalFlowDurationMs); |
Comment on lines
+613
to
+622
| onFinishPerformExecution: async ( | ||
| endedAt: number, | ||
| totalDurationMs: number, | ||
| ) => { | ||
| await onFinishPerformExecutionAction( | ||
| flowRunStartedAt, | ||
| endedAt, | ||
| totalDurationMs, | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| onFinishPerformExecution: async ( | |
| endedAt: number, | |
| totalDurationMs: number, | |
| ) => { | |
| await onFinishPerformExecutionAction( | |
| flowRunStartedAt, | |
| endedAt, | |
| totalDurationMs, | |
| ); | |
| }, | |
| onFinishPerformExecution: (endedAt, durationMs) => | |
| onFinishPerformExecutionAction(flowRunStartedAt, endedAt, durationMs), | |
Comment on lines
+689
to
+695
| onFinishPerformExecution: async (endedAt, durationMs) => { | ||
| await onFinishPerformExecutionAction( | ||
| flowRunStartedAt, | ||
| endedAt, | ||
| durationMs, | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| onFinishPerformExecution: async (endedAt, durationMs) => { | |
| await onFinishPerformExecutionAction( | |
| flowRunStartedAt, | |
| endedAt, | |
| durationMs, | |
| ); | |
| }, | |
| onFinishPerformExecution: (endedAt, durationMs) => | |
| onFinishPerformExecutionAction(flowRunStartedAt, endedAt, durationMs), | |
Comment on lines
+766
to
+772
| onFinishPerformExecution: async (endedAt, durationMs) => { | ||
| await onFinishPerformExecutionAction( | ||
| flowRunStartedAt, | ||
| endedAt, | ||
| durationMs, | ||
| ); | ||
| }, |
There was a problem hiding this comment.
Suggested change
| onFinishPerformExecution: async (endedAt, durationMs) => { | |
| await onFinishPerformExecutionAction( | |
| flowRunStartedAt, | |
| endedAt, | |
| durationMs, | |
| ); | |
| }, | |
| onFinishPerformExecution: (endedAt, durationMs) => | |
| onFinishPerformExecutionAction(flowRunStartedAt, endedAt, durationMs), | |
Comment on lines
+451
to
+454
| onFinishPerformExecution: ( | ||
| endedAt: number, | ||
| durationMs: number, | ||
| ) => Promise<void>; |
There was a problem hiding this comment.
I think this should be Optional.
Suggested change
| onFinishPerformExecution: ( | |
| endedAt: number, | |
| durationMs: number, | |
| ) => Promise<void>; | |
| onFinishPerformExecution?: ( | |
| endedAt: number, | |
| durationMs: number, | |
| ) => Promise<void>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactor recording & reporting agent time usage.
Related Issue
https://github.com/giselles-ai/giselle/pull/251/files#r1891016983