Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor recording & reporting agent time usage #261

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Refactor recording & reporting agent time usage #261

merged 4 commits into from
Dec 20, 2024
+50 −40

Conversation

satococoa
Copy link
Contributor

Summary

Refactor recording & reporting agent time usage.

Related Issue

https://github.com/giselles-ai/giselle/pull/251/files#r1891016983

I would like to separate the recording of the execution from the context of the execution, so it would be better to make it a callback like onFinishPerformFlowExecution and add props like onFinishPerformFlowExecutionAction in the Provider. I think, but in this Pull request, it is fine as it is.

@satococoa satococoa self-assigned this Dec 19, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:16am

toyamarinyon
toyamarinyon approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! We are proposing some minor changes, please check them and apply them if necessary.

app/(playground)/p/[agentId]/contexts/execution.tsx Outdated Show resolved Hide resolved
app/(playground)/p/[agentId]/contexts/execution.tsx Outdated Show resolved Hide resolved
app/(playground)/p/[agentId]/contexts/execution.tsx Outdated Show resolved Hide resolved
app/(playground)/p/[agentId]/contexts/execution.tsx Outdated Show resolved Hide resolved
app/(playground)/p/[agentId]/contexts/execution.tsx Outdated Show resolved Hide resolved
@satococoa satococoa force-pushed the add-agent-activity-recording-to-node-execution branch from fd3c1b6 to 6e1e88d Compare December 20, 2024 00:07
shige
shige approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@shige shige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ♻️

@satococoa satococoa merged commit 3e61ec0 into main Dec 20, 2024
9 checks passed
@satococoa satococoa deleted the add-agent-activity-recording-to-node-execution branch December 20, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shige shige shige approved these changes

@toyamarinyon toyamarinyon toyamarinyon approved these changes

Assignees

@satococoa satococoa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satococoa @toyamarinyon @shige