Consolidate duplicate instrumentation code between node and flow execution #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update ExecutionContext to use a Step type instead of StepId - Simplify step resolution logic in performFlowExecution and retryStep - Improve readability and maintainability of flow execution code
- Extract node and artifact resolution logic into separate functions - Pass ExecutionContext directly where needed to streamline resolutions - Improve code organization and maintainability
- Eliminate the flowId parameter from ExecuteFlowParams and related calls - Simplify function signatures by focusing on necessary parameters - Enhance code clarity and reduce redundancy
- Introduce executeNode function to handle execution for a single node - Update ExecutionProvider to include executeNode method and related logic - Modify PropertiesPanel to call executeNode instead of the previous execute method - Implement flow derivation from a node context for cleaner execution handling - Enhance graph utilities with a test case for one-node scenarios
- Introduce updateArtifact callback to handle live updates of artifacts - Refactor executeStep and executeJob to utilize the new callback - Improve performance of artifact management during flow execution - Ensure consistent state updates across artifact transformations
- Eliminate the action function and its associated logic, as it is no longer needed - Clean up imports in actions, properties panel, and execution contexts to reflect the removal - Streamline codebase by removing redundant artifact management logic in execution
- Refactor executeStep and executeJob to accept callback functions for success and failure handling - Introduce onStepFinish and onStepFail callbacks for better integration of execution outcomes - Update the ExecutionProvider to manage artifact updates and provide step execution feedback - Improve overall artifact management during node processing and execution flow
- Update executeNode function to set the active tab to "Result" when a node is executed - Improve user experience by providing immediate feedback in the UI during execution
|
@toyamarinyon is attempting to deploy a commit to the Edge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I combined overlapping parts in the processing of node execution and flow execution, as there was instrumentation code scattered around.
Since the functionality hasn't changed, it should work the same way as before.
Testing
Execute a node on the playground
/p/:agentIdExecute a flow on the playground
/p/:agentId