Refactor execution #257
Merged
Refactor execution #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consolidate duplicate code between executeStep and retryStep into a shared generateText function. Created ExecutionContext interface to standardize data passing between functions. Key changes: - Extract core text generation logic into standalone generateText function - Add ExecutionContext interface to encapsulate execution state - Remove duplicated node resolution and artifact handling code - Maintain existing functionality while reducing code complexity
Consolidate duplicate flow execution code into reusable performFlowExecution function. Simplifies both new executions and retries through a common path. Key changes: - Create ExecuteFlowParams interface to standardize execution parameters - Extract core flow execution logic into performFlowExecution - Unify execution state management between new and retry flows - Reduce code duplication while maintaining execution behaviors - Simplify job execution status handling
Split execution snapshot building logic into focused utility functions and cleanup initialization code for both new and retry executions. Key changes: - Split buildExecutionsFromSnapshot into separate utility functions - Remove createInitialExecution in favor of direct object creation - Standardize execution state initialization between new and retry flows - Improve type safety with explicit Execution type annotations The refactoring improves clarity by: - Making execution state construction more explicit - Reducing complexity of snapshot handling - Keeping utility functions focused on single responsibilities
|
@toyamarinyon is attempting to deploy a commit to the Edge Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prototype the retry, the code was implemented in hard copy, and each of the instrumentation and other code had to be implemented, so it was refactored to be in one place.