Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the Giselle's logo image in README.md #24

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Added the Giselle's logo image in README.md #24

merged 2 commits into from
Oct 18, 2024

Conversation

shige
Copy link
Member

@shige shige commented Oct 18, 2024 •
edited
Loading

Summary

Added the Giselle's logo image in README.md.

Related Issue

None.

Changes

  • Added the Giselle's logo image in README.md
  • Add docs to .vercelignore

Testing

Other Information

@shige shige added the documentation Improvements or additions to documentation label Oct 18, 2024
@shige shige self-assigned this Oct 18, 2024
@shige shige requested a review from toyamarinyon as a code owner October 18, 2024 05:40
@vercel Vercel
Copy link

vercel bot commented Oct 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
giselle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 5:47am

toyamarinyon
toyamarinyon reviewed Oct 18, 2024
View reviewed changes
Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a text logo would be better.

image

toyamarinyon
toyamarinyon approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@toyamarinyon toyamarinyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The product name is written in text and should remain as it is now.

@shige
Copy link
Member Author

shige commented Oct 18, 2024

Thanks!

@shige shige merged commit e73ebb5 into main Oct 18, 2024
6 checks passed
@shige shige deleted the update-readme branch October 18, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toyamarinyon toyamarinyon toyamarinyon approved these changes

Assignees

@shige shige

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shige @toyamarinyon