Feat/persist #4
Feat/persist #4
Conversation
arlas/cli/collections.py
Outdated
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| @collections.callback() | |||
| def configuration(config: str = typer.Option(help="Name of the ARLAS configuration to use from your configuration file ({}).".format(variables["configuration_file"]))): | |||
| variables["arlas"] = config | |||
| variables["arlas"] = config | |||
| ): | ||
| config = variables["arlas"] | ||
| id = Service.persistence_add_file(config, Resource(location=file), zone=zone, name=name, readers=reader, encode=encode) | ||
| print(id) |
There was a problem hiding this comment.
It would be better to add a more meaningful message
There was a problem hiding this comment.
actually it is the id to be used for different usages. I thought that if I do not put text around, it would be easier to use in a script (e.g. to get the ID and put it in a different command line). I can add more details, but it will make the work of the developper a bit more complex to extract the id. Your opinion?
There was a problem hiding this comment.
I didn't have it in mind, I think it is a good idea to do it like you proposed, otherwise it would have to be on multiple lines to be able to grab the id from the last line maybe, but it makes things complicated. If other methods are to be integrated in scripts such as this one and they have a more complicated output, a "dev" or "short answer" mode with a flag could maybe allow for a more verbose answer as well as a direct one for scripts
There was a problem hiding this comment.
yes this (short answer mode flag) is a good idea. For now, I release.
No description provided.