Update latest version checking to avoid warning in dev mode #37
Conversation
| if not version == arlas_cli_version: | ||
| latest_version = json.get("info", {}).get("version", None) | ||
| if latest_version: | ||
| if arlas_cli_version == "_".join(["arlas", "cli", "versions"]): |
There was a problem hiding this comment.
if arlas_cli_version == "arlas_cli_versions":
is good enough.
There was a problem hiding this comment.
I'm worried that it would be changed by the pattern replacement in the file during the release script, which would mean that this condition is always satisfied. It is just one way to create the same string, it can be an other such as "arlas"+"_cli_versions" if you think it looks clearer
There was a problem hiding this comment.
Ok but I do not see how this helps to prevent it?
There was a problem hiding this comment.
and by the way, if we change it, the first thing we will do is a full search in the project on "arlas_cli_versions" and with your solutions we will miss it and therefore the problem you want to avoid will appear.
There was a problem hiding this comment.
As I understand, the sed -i.bak 's/arlas_cli_versions/'${VERSION}'/' target/src/arlas/cli/cli.py replace the arlas_cli_versions in the cli.py file. With the construction I propose, the value is not replaced and I can check if the arlas_cli_version variable still contains "arlas_cli_versions" -which is a local dev usage- or not
(I noticed you added a 's' to avoid replacing the variable itself)
NB In dev mode, the
arlas_cli_versionsstring has not been replaced by the real arlas cli version (it appends during the release script)